Deprecated JBoss cache and uber-webapp modules #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
+1 So these are deprecated in 4.1 and will be removed in 4.2? |
| @@ -18,25 +18,28 @@ | |||
| */ | |||
| package org.jasig.cas.ticket.registry; | |||
|
|
|||
| import java.util.ArrayList; | |||
There was a problem hiding this comment.
was it really worth reformatting? :-)
There was a problem hiding this comment.
I have asked IntelliJ folks to explain this to me :) For some reason, the IDE likes to reformat things for no particular reason, other than to group stuff around in an order that it likes. If you can point me to a setting that would turn this off, I'd be happy to oblige.
|
+1 though in the future we really should try to stick to one issue per pull request. |
|
Yeah, we should attempt to remove these in 4.2. Or rather, take a pass at what's deprecated in the codebase and pretty much remove all. |
|
BTW, the docs are updated as well. |
mmoayyed
pushed a commit
that referenced
this pull request
Sep 20, 2014
Deprecated JBoss cache and uber-webapp modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with https://github.com/Jasig/cas/issues/627 and https://github.com/Jasig/cas/issues/628
This should also be noted in our release notes and possibly posted to the lists as well.