Issue #552 Avoid usage count in SSO opt-out check. #692
Conversation
Reorganize code to perform authentication beforehand and store reference to successful Authentication event that can be consulted for SSO opt-out check afterward.
|
I am OK with this solution, thank you. The only concern I have is, we seem to be executing an unneeded op for a service that is not allowed to do SSO to begin with. That might cause confusion down the road. However, it doesn't seem like that can be avoided... |
|
"we seem to be executing an unneeded op for a service that is not allowed to do SSO to begin with" You mean authentication is the unneeded operation? Assuming yes, then there are two situations:
In either case there is no unnecessary authentication. |
|
Great. Thanks for clarifying this. |
| @@ -296,8 +297,11 @@ public String grantServiceTicket( | |||
| final List<Authentication> authentications = ticketGrantingTicket.getChainedAuthentications(); | |||
| final String ticketPrefix = authentications.size() == 1 ? ServiceTicket.PREFIX : ServiceTicket.PROXY_TICKET_PREFIX; | |||
| final String ticketId = serviceTicketUniqueTicketIdGenerator.getNewTicketId(ticketPrefix); | |||
| final ServiceTicket serviceTicket = ticketGrantingTicket.grantServiceTicket(ticketId, service, | |||
| this.serviceTicketExpirationPolicy, credentials != null); | |||
| final ServiceTicket serviceTicket = ticketGrantingTicket.grantServiceTicket( | |||
There was a problem hiding this comment.
is this following our formatter?
There was a problem hiding this comment.
I honestly don't know. I've used this style elsewhere [1] and it passed muster (build and review), so I assume it's ok.
|
+1 |
1 similar comment
|
+1 |
Issue #552 Avoid usage count in SSO opt-out check.
Reorganize code to perform authentication beforehand and store reference
to successful Authentication event that can be consulted for SSO opt-out
check afterward.
Deals with #552