Management webapp redesign #1083
Conversation
New UI/UX architecture with Bootstrap, Angular and jQuery
UI/UX Updates
Expanded on manage form; adding app js; modified gitignore
…; updated messages.properties
Updated the form with the rest of the values
Conflicts: .gitignore cas-management-webapp/src/main/webapp/WEB-INF/view/jsp/manage.jsp pom.xml
Modified form with feedback from tech lead
Added functionality to the manage services table
|
This pull is ready to be merged. All issues have been fixed. |
|
ping @leleuj would like to expedite the release. Think we can merge this and work through issues by end of week? |
|
I'm not sure I will have time to review everything, I'll try to take a look at least. I'll make a test before the end of the week and let you know. |
|
Thanks. I'd recommend pulling down the branch and testing it purely from a functional perspective. Code reviews may not be entire feasible as most changes are UI based and I have complete trust in our fellow UI devs to have done a good job. We'll mark this to merge by Friday unless you or anyone else discovers bugs. |
|
Ping. Getting ready to merge by tomorrow evening EDT. |
|
PS I will also merge this branch into heroku |
|
Wow! What a great job! You did that on your own? I just quickly did a few tests, it seems to work for most of the features I tested. A few comments:
If we have a great UI, why would we move it out of the CAS project? I was in favor of dropping the UI if we could not maintain it, but as we have a great UI and as it heavily relies on the cas-server-core module, I think we should keep it in the CAS project. |
|
I did a few parts of it on my own :) I had great help with a few UI experts and I am forever thankful to them.
They have not. When you define a pattern, it is first checked to see if it's a valid regex. If not, the code switches back to Ant. I am guessing most patterns you defined where valid regex.
That's a bug. I'll review.
I brought up this point during development. I was told this is not good UI design. Apparently, you still want the user to keep editing stuff even if that stuff isn't going to be applicable.
Yes.
The option allows you release the PGT directly in the validation response, provided service is allowed to do proxy authentication.
Technically, it's a collection of authentication handler bean ids. Will clarify.
Will clarify. It's used to encrypt credential/PGT data.
Agreed. I'll see if I can make the change.
We can work on this. |
|
OK. Forget my comment about the default service. |
Had a look. This is not true. What the checkbox says, CAS should require all attributes/values to grant access to the service. If left unchecked, the first match will succeed. So, you could still have many attributes defined and they will be ORed together. So the pane should still remain visible. |
|
All feedback has been accounted for. |
|
So @leleuj I am assuming you are satisfied by the pull? |
|
Yes, great job! |
Closes https://github.com/Jasig/cas/issues/496
There are a few more issues to work out, but I will leave this pull open as we merge changes into the branch so others can review and test.
This is the last wrinkle in 4.1 release.