#1049 - Fix serialization bug with EhcacheTicketRegistry #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +37,12 @@ | |||
|
|
|||
| @Override | |||
| public void populateAttributes(final AuthenticationBuilder builder, final Credential credential) { | |||
| builder.addAttribute(SUCCESSFUL_AUTHENTICATION_HANDLERS, new HashSet(builder.getSuccesses().keySet())); | |||
| Set<String> successes = builder.getSuccesses().keySet(); | |||
There was a problem hiding this comment.
For my understanding, when are the successes null? Should it ever happen?
There was a problem hiding this comment.
No it never should. When the populator runs, it is assumed that authN is successful. Need to double check, but I think that is the current behavior.
|
@Ammar0 any updates on this? |
Member
mmoayyed
commented
<
8000
a href="#issuecomment-126183203" id="issuecomment-126183203-permalink" class="Link--secondary js-timestamp">Jul 30, 2015
|
@leleuj in light of the next patch release, how about we merge this for now and fix up other issues locally? Don't think we can update this PR in time. |
|
This should also be merged into 4.0.x |
|
I'm not against it. At worst, it's a useless check. |
mmoayyed
pushed a commit
that referenced
this pull request
Jul 30, 2015
#1049 - Fix serialization bug with EhcacheTicketRegistry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1049