8000 fix(docker-jans-monolith): update scripts location by misba7 · Pull Request #10481 · JanssenProject/jans · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(docker-jans-monolith): update scripts location #10481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix(docker-jans-monolith): update scripts location #10481

merged 2 commits into from
Dec 23, 2024

Conversation

misba7
Copy link
Contributor
@misba7 misba7 commented Dec 23, 2024

#7746

closes #10433

@misba7
fix(monolithic): update scripts location
0cceaf8 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@misba7 misba7 requested review from moabu and iromli as code owners December 23, 2024 08:06
@dryrunsecurity DryRunSecurity
Copy link
dryrunsecurity bot commented Dec 23, 2024 •
edited
Loading

DryRun Security Summary

The pull request focuses on improving the deployment and startup processes of the Janssen application through updates to the Dockerfile, Docker Compose documentation, and entrypoint script, with considerations for security and configuration management.

Expand for full summary

Summary:

The code changes in this pull request are primarily focused on updates to the Janssen (Jans) application's deployment and startup processes. The changes involve updates to the Dockerfile for the "docker-jans-monolith" application, improvements to the Docker Compose installation documentation, and modifications to the entrypoint script for the Janssen services.

From an application security perspective, the changes appear to be generally positive, as they address aspects such as health checks, system file cleanup, and improvements to the deployment and startup process. However, there are a few areas that warrant further review to ensure the security of the application:

  1. Ensuring that all sensitive configuration values, such as passwords and credentials, are properly secured and not exposed in the environment or configuration files.
  2. Reviewing the security implications of using the provided Docker image for production deployments, as it is mentioned to be for testing and development purposes only.
  3. Evaluating the security of the external access setup, which relies on modifying the /etc/hosts file, and ensuring that proper DNS and SSL/TLS configurations are in place for production environments.
  4. Verifying that the Java-based tests and their test data do not introduce any security vulnerabilities.
  5. Confirming that the certificate management and secure communication between the application components are properly implemented.

Overall, the changes in this pull request appear to be focused on improving the deployment and startup process of the Janssen application, but it is important to review the security implications of these changes to ensure the ongoing security and integrity of the application.

Files Changed:

  1. docker-jans-monolith/Dockerfile:

    • The HEALTHCHECK command has been updated to use the correct location for the jans-auth script.
    • Some system files have been removed, likely for optimization and cleanup purposes.

  2. docs/janssen-server/install/docker-install/compose.md:

    • The documentation has been updated to use the term "Janssen" instead of "Gluu flex".
    • The instructions cover setting up various environment variables, including sensitive values like the Janssen admin password and test client credentials.
    • The documentation mentions that the provided Docker image is for testing and development purposes only, and that the Janssen Helm charts should be used for production setups.
    • The instructions for accessing the Janssen server externally suggest using a DNS record in the /etc/hosts file, which may not be suitable for production environments.

  3. docker-jans-monolith/scripts/entrypoint.sh:

    • The paths to the Janssen service startup scripts have been updated to reflect a change in the directory structure or packaging of the application.
    • The script ensures that various Janssen services are started when the container is launched.
    • The script sets up configuration properties for the Janssen application, which should be properly sanitized and validated.
    • The script includes functionality to prepare and run Java-based tests for the Janssen components, which should be reviewed for potential security vulnerabilities.
    • The script uses the certbot tool to register the FQDN with Let's Encrypt and import the SSL/TLS certificate into the Java keystore, which are important security measures.

Code Analysis

We ran 9 analyzers against 3 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 1 finding

View PR in the DryRun Dashboard.

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-monolith comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality labels Dec 23, 2024
@misba7 misba7 changed the title fix(monolithic): update scripts location fix(docker-jans-monolith): update scripts location Dec 23, 2024
@moabu moabu merged commit 45fe7a5 into main Dec 23, 2024
11 checks passed
@moabu moabu deleted the fix-jans-scripts branch December 23, 2024 14:16
@mo-auto mo-auto mentioned this pull request Dec 23, 2024
Merged
ossdhaval pushed a commit that referenced this pull request Dec 27, 2024
@misba7 @moabu
fix(docker-jans-monolith): update scripts location (#10481)
46241f2 
fix(monolithic): update scripts location

Signed-off-by: Amro Misbah <amromisba7@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@iromli iromli Awaiting requested review from iromli iromli is a code owner

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-monolith comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-monolith-docker): Install Script fails due to missing jans-auth folder
3 participants
@misba7 @moabu @mo-auto
0