8000 Enhance Per Diem API Documentation · Issue #82 · GSA/GSA-APIs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enhance Per Diem API Documentation #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvogelgesang opened this issue Aug 7, 2020 · 1 comment
Open

Enhance Per Diem API Documentation #82

mvogelgesang opened this issue Aug 7, 2020 · 1 comment

Comments

@mvogelgesang
Copy link

The request and response documentation for the Per Diem API could provide greater detail. For instance, Endpoint 1: https://api.gsa.gov/travel/perdiem/v2/rates/city/{city}/state/{ST}/year/{year} could specify that {ST} requires a state abbreviation and does not support long form state names. The Expected Result claims two values in the response but in reality, it is much longer (see below).

{
    "request": null,
    "errors": null,
    "rates": [
        {
            "oconusInfo": null,
            "rate": [
                {
                    "months": {
                        "month": [
                            {
                                "value": 152,
                                "number": 1,
                                "short": "Jan",
                                "long": "January"
                            },
                            {
                                "value": 152,
                                "number": 2,
                                "short": "Feb",
                                "long": "February"
                            },
                            {
                                "value": 152,
                                "number": 3,
                                "short": "Mar",
                                "long": "March"
                            },
                            {
                                "value": 152,
                                "number": 4,
                                "short": "Apr",
                                "long": "April"
                            },
                            {
                                "value": 152,
                                "number": 5,
                                "short": "May",
                                "long": "May"
                            },
                            {
                                "value": 152,
                                "number": 6,
                                "short": "Jun",
                                "long": "June"
                            },
                            {
                                "value": 152,
                                "number": 7,
                                "short": "Jul",
                                "long": "July"
                            },
                            {
                                "value": 152,
                                "number": 8,
                                "short": "Aug",
                                "long": "August"
                            },
                            {
                                "value": 159,
                                "number": 9,
                                "short": "Sep",
                                "long": "September"
                            },
                            {
                                "value": 159,
                                "number": 10,
                                "short": "Oct",
                                "long": "October"
                            },
                            {
                                "value": 152,
                                "number": 11,
                                "short": "Nov",
                                "long": "November"
                            },
                            {
                                "value": 152,
                                "number": 12,
                                "short": "Dec",
                                "long": "December"
                            }
                        ]
                    },
                    "meals": 66,
                    "zip": null,
                    "county": "Fulton / Dekalb",
                    "city": "Atlanta",
                    "standardRate": "false"
                }
            ],
            "state": "GA",
            "year": 2019,
            "isOconus": "false"
        }
    ],
    "version": null
}
@arkjoseph
Copy link

@mvogelgesang - thank you for your feedback and will take into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
0