8000 eps_t unused in private/fnft__nsep_testcases.c · Issue #43 · FastNFT/FNFT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

eps_t unused in private/fnft__nsep_testcases.c #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of servi 8000 ce and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marbre opened this issue Oct 9, 2019 · 2 comments
Open

eps_t unused in private/fnft__nsep_testcases.c #43

marbre opened this issue Oct 9, 2019 · 2 comments
Assignees
@wahls

Comments

@marbre
Copy link
Contributor
marbre commented Oct 9, 2019

Taking a deeper look into the code, I noticed that eps_t is initialized as

FNFT/src/private/fnft__nsep_testcases.c

Line 187 in bcd8767

eps_t = (T[1] - T[0])/D; // location of last sample is T[1]-eps_t

However, eps_t seems not to be used afterwards.
@wahls wahls self-assigned this Oct 10, 2019
@wahls
Copy link
Contributor
wahls commented Oct 10, 2019

Seems like you are right. Will remove this in the next smaller release. Thanks!

@marbre
Copy link
Contributor Author
marbre commented Oct 14, 2019

I just wasn't 100% certain, but in the case it is unused, I might send a PR and will refactor the eps_t usage in the specific file a little bit more than just deleting the line.

@marbre marbre mentioned this issue Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wahls wahls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wahls @marbre
0