8000 Fix style guide example not using local std by IGI-111 · Pull Request #4721 · FuelLabs/sway · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix style guide example not using local std #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fix style guide example not using local std #4721

merged 1 commit into from
Jun 30, 2023

Conversation

IGI-111
Copy link
Contributor
@IGI-111 IGI-111 commented Jun 29, 2023

Description

Style guide example is blocking new releases because it tries to use an unpublished version of std

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added the bug Something isn't working label Jun 29, 2023
@IGI-111 IGI-111 requested review from Braqzen and a team June 29, 2023 21:30
@IGI-111 IGI-111 self-assigned this Jun 29, 2023
sdankel
sdankel approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member
@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IGI-111 IGI-111 requested a review from a team June 29, 2023 22:03
@JoshuaBatty JoshuaBatty merged commit 0d45b89 into master Jun 30, 2023
@JoshuaBatty JoshuaBatty deleted the IGI-111/v0.41.0 branch June 30, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sdankel sdankel sdankel approved these changes

@Braqzen Braqzen Awaiting requested review from Braqzen

Assignees

@IGI-111 IGI-111

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGI-111 @JoshuaBatty @sdankel
0