HttpResponderBuilder.setResponder has no use #17

huksley · 2016-05-19T05:39:38Z

field HttpResponderBuilder.responder is practically immutable, because in
MockHttpServer.respondTo it is used directly without ability to override later.

huksley · 2016-05-19T05:40:15Z

There is no way to implement advanced scenarious which need modifiying response based on actual request body.

huksley · 2016-05-19T05:55:49Z

Here is possible implementation:

class OverridableHttpResponderBuilder extends HttpResponderBuilder {
    HttpRequestMatcher matcher;
    MockHttpServer server;

    public OverridableHttpResponderBuilder(HttpRequestMatcher matcher, MockHttpServer server) {
        this.matcher = matcher;
        this.server = server;
    }

    public OverridableHttpResponderBuilder responder(HttpResponder r) {
        super.setResponder(r);
        server.getHandler().getResponders().put(matcher, getResponder());
        return this;
    }
}

class OverridableMockHttpServer extends MockHttpServer {
    OverridableHttpResponderBuilder respondTo2(HttpRequestMatcher m) {
        OverridableHttpResponderBuilder b = new OverridableHttpResponderBuilder(m, this);
        getHandler().getMatchers().add(0, m);
        getHandler().getResponders().put(m, b.getResponder());
        return b;
    }
}

and invoked with:

server.respondTo2(anyRequest()).responder(new HttpResponder() {
            @Override
            public void render(ClientRequest request, HttpServletResponse response) {
                super.render(request, response);
            }
        }).withStatus(404).withBody("<error>Not found</error>");

rhoegg · 2016-05-19T06:28:32Z

I prefer the responder field to be immutable in the Builder, since each method call mutates its state.

The current way to use request information in the response is by providing a bodyClosure through HttpResponderBuilder.withBody(Closure). If you want to control something other than the response body, I could see adding some overloads that take Closures to withHeader or withStatus.

The spirit of the library is to provide a simple way to express the behavior of a web service in the context of a single test method. Often, a dynamic stubbed response can be replaced with several test methods, each with a static response.

rhoegg · 2016-05-19T06:29:46Z

Also, ongoing development has been happening on the sham-http fork

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HttpResponderBuilder.setResponder has no use #17

HttpResponderBuilder.setResponder has no use #17

HttpResponderBuilder.setResponder has no use #17

HttpResponderBuilder.setResponder has no use #17

Comments