[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ARC as default for target configuration #2262

Closed
onato opened this issue Jun 23, 2014 · 9 comments · Fixed by #2769
Closed

Switch to ARC as default for target configuration #2262

onato opened this issue Jun 23, 2014 · 9 comments · Fixed by #2769
Labels
d1:easy An easy ticket that is a good start for first-time contributors s2:confirmed Issues that have been confirmed by a CocoaPods contributor t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it

Comments

@onato
Copy link
Contributor
onato commented Jun 23, 2014

At present each Cocoapods targert is set to CLANG_ENABLE_OBJC_ARC=NO and every ARC file is flagged with -fobjc-arc.

It would make more sense to set CLANG_ENABLE_OBJC_ARC=YES and flag the non-ARC files with -fno-objc-arc

The reason for this is when I edit a storyboard in a pod, Interface Builder generates non-ARC code for me.

@segiddins
Copy link
Member

Closing as a duplicate of #267.

@fabiopelosin
Copy link
Member

This is a different issue. The current behaviour was done to support old deployment targets ('4.0') if I recall correctly. @alloy can we switch this behaviour?

@orta
Copy link
Member
orta commented Jul 25, 2014

^ this change would be super useful, as it's the main reason for the warning above this title: http://guides.cocoapods.org/making/using-pod-lib-create#adding-travis-ci

@alloy
Copy link
Member
alloy commented Jul 25, 2014

@irrationalfab I don’t understand, I think you’re confused with treating dispatch types as objects. Afaik this is indeed a duplicate of #267.

@fabiopelosin
Copy link
Member

@alloy that was about only changing the default value of the requires_arc build setting if not specified. Regardless of that default value this logic could have been changed also before but I always avoided to touch it because I remember that you did significant work related to this in past related to the CocoaPods setup breaking for some deployment targets.

@segiddins
Copy link
Member

@fabiopelosin I'm not understanding your argument that this isn't a duplicate.

@segiddins segiddins added the s1:awaiting input Waiting for input from the original author label Sep 8, 2014
@fabiopelosin
Copy link
Member

@segiddins One thing is to change the default value if the build setting is not specified in the Podspec (true or false) and this has already been done.

The other is to change how the target is configured: either ARC enabled and some files are excluded or ARC disabled and some files are included. Currently the latter approach is in use. I think that it was picked because there was an issue with Xcode 4... so we should attempt to change it.

@segiddins
Copy link
Member

👍

@segiddins segiddins added s2:confirmed Issues that have been confirmed by a CocoaPods contributor d1:easy An easy ticket that is a good start for first-time contributors t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it and removed s1:awaiting input Waiting for input from the original author labels Sep 13, 2014
@segiddins segiddins changed the title Switch to ARC as default Switch to ARC as default for target configuration Sep 13, 2014
@alloy
Copy link
Member
alloy commented Sep 13, 2014

Ah yes, agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d1:easy An easy ticket that is a good start for first-time contributors s2:confirmed Issues that have been confirmed by a CocoaPods contributor t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants