8000 Job.setEnv() wrong "in" test · Issue #420 · CGRU/cgru · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Job.setEnv() wrong "in" test #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebastianelsner opened this issue Oct 15, 2018 · 2 comments
Closed

Job.setEnv() wrong "in" test #420

sebastianelsner opened this issue Oct 15, 2018 · 2 comments

Comments

@sebastianelsner
Copy link
Contributor

if self.data not in ["environment"]:

the test should be:

if "environment" not in self.data:

the old line would only allow ONE env var to be set at all.

@timurhai
Copy link
Member

Hi.
Yes! And i only used it for one variable!
It should be fixed.

@timurhai
Copy link
Member
timurhai commented Oct 15, 2018

Great that you noticed it right now. It will be fixed in 2.3.0, that i am about to create.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
0