8000 Can't reentrant(?) call in StreamingHub · Issue #866 · Cysharp/MagicOnion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Can't reentrant(?) call in StreamingHub #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
prisira opened this issue Oct 31, 2024 · 3 comments
Open

Can't reentrant(?) call in StreamingHub #866

prisira opened this issue Oct 31, 2024 · 3 comments
Labels
stale stale not updated issue & pr

Comments

@prisira
Copy link
prisira commented Oct 31, 2024 •
edited
Loading

Using MagicOnion 7.0.0-preview.10

In StreamingHub

Server <- Client
   |
   v
Server -> Client
            |
            v
Server <- Client
  No response returned here...

Would like to know if there is a plan to make this possible.
@mayuki
Copy link
Member
mayuki commented Nov 1, 2024

Is the server calling the client a broadcast or client results? Is it something like the following?
In any case, the Hub method processes in serial for the client, so if the Hub methods wait for each other, a deadlock will occur.

Client results

sequenceDiagram
    Client->>+Server: Invoke HubMethodA
    Server->>+Client: Invoke ClientMethodA
    Client->>+Server: Invoke HubMethodB
    Server-->>-Client: Return from HubMethodB
    Client-->>-Server: Return from ClientMethodA
    Server-->>-Client: Return from HubMethodA
Loading

Broadcast

sequenceDiagram
    Client->>+Server: Invoke HubMethodA
    Server->>+Client: OnBroadcastMethodA
    Server-->>-Client: Return from HubMethodA
    Client->>Server: Invoke HubMethodB
    Server-->>Client: Return from HubMethodB
Loading

@prisira
Copy link
Author
prisira commented 9339 Nov 1, 2024 •
edited
Loading

Thank you for the detailed diagram.

Yes, the “Client Results” case is being used.
I see, a deadlock occurs when multiple duplex calls are made simultaneously.

In cases where the Client and Server need to communicate closely, this prevents the use of mechanisms like try/catch or a using scope, making the implementation much more complicated.
I would be very grateful if this could be improved.

And... If the Hub method processes are sequential, Then I realized there is a workaround using Task.Run in a method, but this method is challenging to use because it does not properly wait for the complete.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 1, 2025

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale stale not updated issue & pr label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale stale not updated issue & pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mayuki @prisira
0