Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 16 commits
- 60 files changed
- 8 contributors
Commits on Mar 29, 2024
Commits on Apr 10, 2024
-
Fix Go Report Card Issues (#131)
* Fix ineffassign * Fix ineffassign * Fix misspell * Fix gocyclo * Return error * @ccoVeille s suggestion * Returning error Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com> * Removed interface{} to solve type problems. > > Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com> * Comment Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com> * Fix file output on quiet flag * Delete test/result.json * Changed 1 test * Test fix * remove test.txt * Coverage test Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com> --------- Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
-
Commits on Apr 11, 2024
-
* chore: format files before working on them files were formatted with gofumpt * fix: make sure to always wrap errors This is the only way to be able to catch a specific error with errors.Is in the code calling the method * fix: errors have to be manipulated with care The existing code could lead to errors with wrapped errors - using `if err == whatever` don't catch wrapped errors - using type assertion could lead to panic * fix: error returned by reporters must be handled * fix: misuage of WalkDirFunc * chore: fix some typos and error in the struct * chore: remove unused receivers The code is then clearer * chore: Replace all interface{} by any any is available since Go 1.18, it makes code clearer. * chore: use uppercase for JSON, XML, and YAML acronyms * chore: use simpler name for cli Option an option of cli doesn't need to be named cli.CLIOption * chore: avoid shadowing import when importing something from cli package, we shouldn't name a variable cli * chore: avoid useless else The code is clearer to understand. * chore: remove unused assertErrorIs and accept assert.Error -
Commits on Apr 16, 2024
Commits on May 29, 2024
-
Enable openssf scorecard (#151)
* initialize openssf scorecard * test-scorecard-on-PR * add scorecard badge to README * increasing timeout in golangci workflow * Add scorecard badge to index.md * Update .github/workflows/scorecard.yml Co-authored-by: Jamie Davidson <51518462+jd4235@users.noreply.github.com> * Update scorecard.yml --------- Co-authored-by: Jamie Davidson <51518462+jd4235@users.noreply.github.com>
-
-
Improve Scorecard scores (#152)
* add openssf best practices badge * adding security * remove binary file * improving workflow security * addings SHAs to base containers * fixing workflows * fixing workflows * updating security text
Commits on May 30, 2024
-
ci(goreportcard): Add step for goreportcard check (#149)
Go report card for repo: https://goreportcard.com/report/github.com/Boeing/config-file-validator Fixes #120 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Commits on Aug 3, 2024
-
EditorConfig file type #145 (#157)
* EditorConfig file type * Removed deprecated ParseBytes function * Update pkg/filetype/file_type.go --------- Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
-
-
-
small optimization for fsfinder (#136)
* changed []string to map[string]struct{} in FileSystemFinder struct fields because of optimization (arrays were used only to check the occurrence of an element) * Changed field Extensions type in FileType from []string to map[string]struct{} * added requested changes * small refactoring of findOne func * fixd the return value * get back to trimprefix func * cleanup * fsfinder optimization * i hope it fixed * removed unnecessary calls to filepath.Abs * Apply suggestions from code review --------- Co-authored-by: Yaroslav <=> Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
Commits on Aug 12, 2024
Commits on Aug 13, 2024
-
ci: add the permission to release assets (#160)
The release v1.7.0 failed due to the permission error. https://github.com/Boeing/config-file-validator/actions/runs/10362649156/job/28684983356#step:6:284 ``` + github-assets-uploader -logtostderr -f ../validator-v1.7.0-linux-amd64.tar.gz -mediatype application/gzip -repo Boeing/config-file-validator -token *** -tag=v1.7.0 -releasename= -retry 3 W0813 02:34:38.260789 1654 main.go:48] Upload asset error, will retry in 4s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration [] W0813 02:34:42.775738 1654 main.go:48] Upload asset error, will retry in 9s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration [] E0813 02:34:52.242572 1654 err_exit.go:11] POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration [] ``` The permission `contents: write` is required, but it was removed by f28a04d#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34 . So this commit adds the permission.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.6.0...v1.7.0