[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor facetSRPDynamicEffector module #856

Open
leahkiner opened this issue Nov 22, 2024 · 0 comments · May be fixed by #865
Open

Refactor facetSRPDynamicEffector module #856

leahkiner opened this issue Nov 22, 2024 · 0 comments · May be fixed by #865
Assignees
@schaubh @leahkiner
Labels
bug Something isn't working refactor Clean up with no new functionality

Comments

@leahkiner
Copy link
Contributor
leahkiner commented Nov 22, 2024 •
edited
Loading

Describe your use case

The facetSRPDynamicEffector module currently has a bug when mapping the facet normal vectors to the spacecraft body frame. The computed DCM from the facet frame to the body frame must be transposed to obtain the correct transformation. Additionally, the module documentation and code should be cleaned up and reference frames need to be clarified in the PR.

Describe alternatives solutions you've considered
N/A

Additional context
N/A
@leahkiner leahkiner added bug Something isn't working refactor Clean up with no new functionality labels Nov 22, 2024
@leahkiner leahkiner moved this to 🏗 In progress in Basilisk Nov 22, 2024
@leahkiner leahkiner linked a pull request Dec 3, 2024 that will close this issue
Open
@leahkiner leahkiner linked a pull request Dec 3, 2024 that will close this issue
Refactor/856 refactor facet srp dynamic effector #865
Open
@leahkiner leahkiner removed a link to a pull request Dec 3, 2024
Refactor/856 refactor facet srp dynamic effector #865
Open
@leahkiner leahkiner linked a pull request Dec 3, 2024 that will close this issue
Refactor/856 refactor facet srp dynamic effector #865
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schaubh schaubh

@leahkiner leahkiner

Labels
bug Something isn't working refactor Clean up with no new functionality
Projects
Basilisk
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/856 refactor facet srp dynamic effector AVSLab/basilisk
2 participants
@schaubh @leahkiner