-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically suggest to switch themes upon plugin installation #93
Comments
I think #52 might be a requirement for this feature, as the preference page could contain an activator that would track the plugins initialization. |
Anyone have an idea on how this should be done (in terms of implementation)? @ingomohr @PyvesB I was thinking of checking if a custom preference exists in the preference store, and if not, setting it. This preference being set will determine whether the dialog appears or not. The issue is that this will probably occur on every new workspace... maybe there's a better way to do it. |
If the plugin would start automatically (which you typically don't want due to overall performance), we could hook a dialog into plug-in startup (i.e. the activator). Maybe there is another way to run code of a plug-in without the plug-in actually being started. But I don't know about that, yet. |
That's the behaviour if you use the instance scope, but you can have cross-workspace preferences using the configuration scope. More information here. I'm wondering whether this should be implemented at the Platform level rather than in Spectrum alone. Wouldn't it be cool if the IDE automatically displayed "3 new themes were found, click here to open the theme preferences" in one of those new non-blocking popups? |
@PyvesB thank you very much for the reference - that will make implementing this possible :)
I was planning on using the new notification API for this, good idea ;) I wonder if a more generic use case/pattern could be derived from this, for upstream. Obviously. an issue would arise when multiple plugins are installed in one go: the user would be flooded with notifications. This could be discussed in the upstream bug, if we think it's an idea worth persuing. |
Maybe it’d be nice to make a dialog pop up when the user installs the plugin for the first time. The dialog would give the user the option to switch to Spectrum theme by clicking a single button.
This might be especially nice for users new to the plugin, or users who install the plugin but forget to swap themes.
A requirement would be that the dialog is only shown once, when the plugin is originally installed.
The text was updated successfully, but these errors were encountered: