Repaired archive can be incomplete #226
Labels
bug
Something isn't working
Comments
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
repairaction withmlarusesbrotli::BrotliDecompressStreaminReadimpl forCompressionLayerFailSafeReader. While needing more input (brotli::BrotliResult::NeedsMoreInput) brotli can return anoutput_offsetof 0 which is considered as there is no more bytes to read in the current implementation of MLA (compress layer, notably theread()). This is problematic as it can cut some archives before their end.One workaround is to read again (could be multiple times) but it's only a workaround.
Two possible solutions could be:
available_outorwrittenas it needs more input, so we continue reading ;brotli-decompressor(cf. https://github.com/dropbox/rust-brotli-decompressor/blob/master/src/decode.rs#L37), according to their requirements. This one is preferred as MLA would be totally in line with the spec ofRead(https://doc.rust-lang.org/std/io/trait.Read.html#required-methods).The text was updated successfully, but these errors were encountered: