8000 DataSets Support · Issue #155 · AwesomeAssertions/AwesomeAssertions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DataSets Support #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bot 8000 tom
Open
JohnYoungers opened this issue May 12, 2025 · 4 comments
Open

DataSets Support #155

JohnYoungers opened this issue May 12, 2025 · 4 comments

Comments

@JohnYoungers
Copy link

In the release notes for 8.0.0 it notes support for DataSets moves to a separate library: https://awesomeassertions.org/releases/#breaking-changes-for-users

Would there be an AwesomeAssertions version of this? If not, could that be pulled back into the primary library?
@cbersch
Copy link
Contributor
cbersch commented May 12, 2025

We won't pull this back into the primary library.
We can create an AwesomeAssertions version of FluentAssertions.DataSets. We first wanted to wait if there is an actual need for this (see #10 (comment)).

@JohnYoungers
Copy link
Author

I see; thank you! I missed that

I upgraded today and immediately got hit with test failures when comparing two DataTables:

	Expected property results.Columns[0].Table to be , but it contains a cyclic reference.
	Expected property results.Columns[1].Table to be , but it contains a cyclic reference.
	Expected property results.Columns[2].Table to be , but it contains a cyclic reference.
	Expected property results.Columns[3].Table to be , but it contains a cyclic reference.
	Expected property results.Columns[4].Table to be , but it contains a cyclic reference.
	Expected results.DefaultView[0] to be
	System.Data.DataRowView
	{
	    {
	    DataView = System.Data.DataRowView
	        {
	            DataView = {Cyclic reference to type System.Data.DataView detected},
	            IsEdit = False,
	            IsNew = False,
	            Row = System.Data.DataRow

If it's unlikely anyone else would run into similar problems, and setting up the library would be problematic, I can take a look at the original and see what I'd need to port over to get these working

@IT-VBFK
Copy link
Contributor
IT-VBFK commented May 12, 2025 •
edited
Loading

We most definitely won't add this to the main lib again, after stripping this out 😅

But we can fork the FA.DataSets and keep them in maintenance mode, since this would mean adapting breaking changes and pull upstream changes (since this keeps the license of Apache 2.0) only.

But PRs will be welcome for sure...

@JohnYoungers
Copy link
Author

I think going through all of that seems a bit excessive, especially if it'll be considered deprecated for the most part

Later in the week I'll try upgrading again and seeing which pieces would be required for my use case: if it's minimal and doesn't come with baggage, maybe that would make sense to include in the primary library?

I'm guessing the answer to that is most likely 'hard no' based on the first sentence of both replies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbersch @JohnYoungers @IT-VBFK
0