Open
Description
Some of the patches in master have swapped the byte ordering for IPv4 DNS server, and subsequently broken --foreign-option DNS.
Client log, on commit 9ecaf2400a7b3 + gerrit#838, calling out to an --up script that does nothing but call env
2025-05-02 19:13:00 PUSH: Received control message: 'PUSH_REPLY,route 10.194.0.0 255.255.0.0,route-ipv6 fd00:abcd:194::/48,tun-ipv6,route 10.194.2.1,topology net30,ping 10,ping-restart 30,dns server 1 resolve-domains open.vpn,dns server 1 address 10.194.0.1,dns server 1 address fd00:abcd:194::1,dns server 2 resolve-domains open.vpn,dns server 2 address 10.194.1.1,dns server 2 address fd00:abcd:194:1::1,ifconfig-ipv6 fd00:abcd:194:2::102b/64 fd00:abcd:194:2::1,ifconfig 10.194.2.178 10.194.2.177,peer-id 3,cipher AES-256-GCM,key-derivation tls-ekm'
so there's good DNS data
foreign_option_1=dhcp-option DNS 1.0.194.10
foreign_option_2=dhcp-option DNS6 fd00:abcd:194::1
foreign_option_3=dhcp-option DNS 1.1.194.10
foreign_option_4=dhcp-option DNS6 fd00:abcd:194:1::1
and IPv4 passed to env is broken.
I'm just noting this here so it's not overlooked - it might get fixed in one of the patches of the --dns series, but if not, please add one to fix this :-)