-
Notifications
You must be signed in to change notification settings - Fork 7
minor clarification of ucorrelate description #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for your input, we always welcome clarifications to the docs. To your point, "uniformly-spaced intervals" already means "with the same interval size", no? We should add the missing dash though. |
The current wording allows for the possibility that one time series is
uniformly-spaced with an interval of 1 second, while the second is
uniformly-spaced with an interval of 2 seconds. I'm trying to convey the
idea that the intervals must be the same between the two time series.
Phillip
…On Wed, Aug 15, 2018 at 11:42 AM Antonino Ingargiola < ***@***.***> wrote:
Thanks for your input, we always welcome clarifications to the docs.
To your point, "uniformly-spaced intervals" already means "with the same
interval size", no? We should add the missing dash though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBBxM4Bo66k79gKVwmb32oSynAzq6SLks5uRGuTgaJpZM4V9jTA>
.
|
Ok, now I understand your point. What about this? The classical text-book linear cross-correlation between two signals defined at uniformly-spaced intervals (both signals having the same interval size). |
That's perfect. (Except, "textbook" should be written without a hyphen).
thanks!
…On Sat, Aug 18, 2018 at 5:29 AM Antonino Ingargiola < ***@***.***> wrote:
Ok, now I understand your point. What about this?
*The classical text-book linear cross-correlation between two signals
defined at uniformly-spaced intervals (both signals having the same
interval size)*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBBxPVPYS23Ag8wJL5JeAD_269Aroykks5uSAi_gaJpZM4V9jTA>
.
|
Thanks @Phillip-M-Feldman, I committed the fix. |
The documentation for ucorrelate says the following: "The classical text-book linear cross-correlation between two signals defined at uniformly spaced intervals." I know that it is fairly obvious, but it would nevertheless be good to restate as follows: "The classical textbook linear cross-correlation between two signals defined at uniformly-spaced intervals with the same interval size."
The text was updated successfully, but these errors were encountered: