8000 minor clarification of ucorrelate description · Issue #3 · OpenSMFS/pycorrelate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

minor clarification of ucorrelate description #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Phillip-M-Feldman opened this issue Aug 15, 2018 · 5 comments
Closed

minor clarification of ucorrelate description #3

Phillip-M-Feldman opened this issue Aug 15, 2018 · 5 comments

Comments

@Phillip-M-Feldman
Copy link

The documentation for ucorrelate says the following: "The classical text-book linear cross-correlation between two signals defined at uniformly spaced intervals." I know that it is fairly obvious, but it would nevertheless be good to restate as follows: "The classical textbook linear cross-correlation between two signals defined at uniformly-spaced intervals with the same interval size."

@tritemio
Copy link

Thanks for your input, we always welcome clarifications to the docs.

To your point, "uniformly-spaced intervals" already means "with the same interval size", no? We should add the missing dash though.

@Phillip-M-Feldman
Copy link
Author
Phillip-M-Feldman commented Aug 16, 2018 via email

@tritemio
Copy link

Ok, now I understand your point. What about this?

The classical text-book linear cross-correlation between two signals defined at uniformly-spaced intervals (both signals having the same interval size).

@Phillip-M-Feldman
Copy link
Author
Phillip-M-Feldman commented Aug 18, 2018 via email

@tritemio
Copy link

Thanks @Phillip-M-Feldman, I committed the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
0