[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations needed for comparison functionality messages #905

Open
securestep9 opened this issue Sep 17, 2024 · 6 comments
Open

Translations needed for comparison functionality messages #905

securestep9 opened this issue Sep 17, 2024 · 6 comments
Labels
good first issue l10n

Comments

@securestep9
Copy link
Collaborator
securestep9 commented Sep 17, 2024 •
edited
Loading

We are looking for contributors to help translate the following scan-comparison-related messages into various languages. If you are a native speaker of any of the languages listed below, please consider contributing a translation for the following messages(no Google Translate please, only native speaker translations):

compare_report_path_filename: "the file-path to store the compare_scan report"
no_scan_to_compare: "the scan_id to be compared not found"
compare_report_saved: "compare results saved in {0}"
build_compare_report: "building compare report"
finish_build_report: "Finished building compare report"

Languages needed:

Arabic (ar.yaml)
Bengali (bn.yaml)
German (de.yaml)
Greek (el.yaml)
Spanish (es.yaml)
Persian (fa.yaml)
French (fr.yaml)
Hindi (hi.yaml)
Armenian (hy.yaml)
Indonesian (id.yaml)
Italian (it.yaml)
Hebrew (iw.yaml)
Japanese (ja.yaml)
Korean (ko.yaml)
Dutch (nl.yaml)
Pashto (ps.yaml)
Portuguese (Brazil) (pt-br.yaml)
Russian (ru.yaml)
Turkish (tr.yaml)
Urdu (ur.yaml)
Vietnamese (vi.yaml)
Chinese (Simplified) (zh-cn.yaml)

These YAML files are located here: https://github.com/OWASP/Nettacker/tree/master/nettacker/locale
Feel free to submit a pull request with your translations. Thank you for your contributions!
@arkid15r arkid15r added the l10n label Sep 17, 2024
@Captain-T2004 Captain-T2004 mentioned this issue Sep 18, 2024
Merged
5 tasks
@onass1 onass1 mentioned this issue Sep 18, 2024
Merged
8 tasks
securestep9 added a commit that referenced this issue Sep 19, 2024
@securestep9
Merge pull request #908 from onass1/Arabic-Translation-for-ar.yaml
424b8b6 
Adding Arabic translations for scan comparison (issue: #905)
@tadash10
Copy link
Contributor
tadash10 commented Oct 1, 2024

hi ! I'm a native Spanish speaker .Do I make a pull request with the translation I already made? Do I have to take any precautions? Thank you!

@arkid15r
Copy link
Collaborator
arkid15r commented Oct 1, 2024

hi ! I'm a native Spanish speaker .Do I make a pull request with the translation I already made? Do I have to take any precautions? Thank you!

@tadash10 if you want to update es localization please go ahead and create a regular GitHub PR. Thanks for contributing!

tadash10 added a commit to tadash10/Nettacker that referenced this issue Oct 1, 2024
@tadash10
Update es.yaml
536b5f0 
Added Spanish translations for scan comparison (issue  OWASP#905 )

Signed-off-by: T1 <126980610+tadash10@users.noreply.github.com>
@tadash10 tadash10 mentioned this issue Oct 1, 2024
Merged
8 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 3, 2024
@arkid15r
Merge pull request #934 from tadash10/patch-2
d61e78a 
Added Spanish translations for scan comparison (issue  #905 )
@Phantomwise
Copy link
Contributor
Phantomwise commented Oct 26, 2024 •
edited
Loading

Hi! Would I need to follow the part of the contribution guidelines about testing code in order to submit a french translation ? I don't know much python and that seems way over my head 😅

@arkid15r
Copy link
Collaborator

Hi! Would I need to follow the part of the contribution guidelines about testing code in order to submit a french translation ? I don't know much python and that seems way over my head 😅

Hi @Phantomwise, it's always a good idea to test functionality and/or write unit tests for your code. For l10n related PRs it's not always required (see similar PR -- #934). Just making sure unit tests and CI/CD green after your changes should be enough.

@Phantomwise
Copy link
Contributor
Phantomwise commented Oct 26, 2024 •
edited
Loading

Ok, I thought I could do just the translation part, but if it requires testing I'll have to pass, I'm not qualified for that sadly. I'm not a developer, just looking for translation requests.

@arkid15r
Copy link
Collaborator

All you need to do is just make sure the app works after your changes. If that's out of your knowledge/qualification -- just go ahead and translate it similar to how it's done in #934 (no test added in that PR). The CI/CD will take care of that.

Thank you for the contribution!

@Phantomwise Phantomwise mentioned this issue Oct 26, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue l10n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arkid15r @securestep9 @tadash10 @Phantomwise