-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Exception #401
Comments
@securestep9 If you found this as a valid issue, then I would like to take up this issue. |
Hi @itsdivyanshjain , yes, it is a valid point to improve code quality. Please do check and review PR #403 first - DeepSource tool was used to analyse the code to find few other code quality issues |
Sure @securestep9 . I will do that |
Hi @itsdivyanshjain |
Hey @Rohan-Salwan, Nettacker does have set of messages, but when it breaks it goes for an exception and print the particular line from a set of messages which may be deceptive. In case of issue #398 it's showing P.s: currently Nettacker going from lot of changes because of that you should wait for changes to merge then send PR if you want any improvement. |
We should use
except exception as e
instead of onlyexcept exception
, otherwise it often difficult to debug the code. Like in issue #398 it shows module not exists because of import error in that module. This often deceiving and sometimes take bit of our time.OS:
Backbox
OS Version:
7.1
Python Version:
3.8.5
The text was updated successfully, but these errors were encountered: