8000 I want to deploy it to a web application, I follow the docs, but failed. · Issue #831 · OHIF/Viewers · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

I want to deploy it to a web application, I follow the docs, but failed. #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RainMaker-Q opened this issue Aug 30, 2019 · 9 comments
Closed

I want to deploy it to a web application, I follow the docs, but failed. #831

RainMaker-Q opened this issue Aug 30, 2019 · 9 comments
Assignees
@dannyrb

Comments

@RainMaker-Q
Copy link

Hi, I am new here, these days I try to deploy ohif viewers into a web application , but it's hard to do it when I follow the docs.

Description

It seem that the docs is a little old.The docs tell me to download the react branch, but I can't find the react branch. And the docs tell me to input yarn run build:web, but this version don't have this command.
I try to use the master branch , go to platform/viewers and input build:viewer ,and I copy the dist folder into a tomcat's webapps.But it doesn't work. I can't see the ohif viewer on the browser.I really have no idea about how to deploy the application.
in short,I have 3 questions:

  • which branch is suit for deploy.
  • which command I shoule type if I want to deploy it.
  • If tomcat could deploy the application?If not, what can?

Thank you for reading here. I will appreciate it if you can give me some advise.
@dannyrb dannyrb self-assigned this Aug 30, 2019
@dannyrb
Copy link
Member
dannyrb commented Aug 30, 2019

@lrqlrq, we've had a few major releases, and one large restructuring since those docs were written. Unfortunately, the items most impacted were those related to file locations and npm scripts. You can read more about how/where things now live here:

#768

More than happy to accept even very small behaviors to clean up what is now incorrect. After we have all of our CI updated, and IE + Edge functionality working as expected, rectifying docs are the next highest priority.

@dannyrb
Copy link
Member
dannyrb commented Aug 30, 2019

which branch is suit for deploy.

master

which command I shoule type if I want to deploy it.

It depends on your use case, but most likely yarn run build from the repository root to generate the static assets you should deploy.

If tomcat could deploy the application?If not, what can?

Any web server capable of serving up static assets will suffice.

@RainMaker-Q
Copy link
Author

which branch is suit for deploy.

master

which command I shoule type if I want to deploy it.

It depends on your use case, but most likely yarn run build from the repository root to generate the static assets you should deploy.

If tomcat could deploy the application?If not, what can?

Any web server capable of serving up static assets will suffice.

Thank you very very much!! I will have a try!

@dannyrb
Copy link
Member
dannyrb commented Sep 6, 2019

@lrqlrq any updates?

@RainMaker-Q
Copy link
Author

@dannyrb Thank you for still remember me! I was touched by you.
I am a little busy these days, just did little updates about viewers. Here are my new questions I met:

  1. I tried to follow what you said, but the console shows these errors. I think I probabely ignored some important config files.
    image
  2. I want to build the Nginx + Image + Archive and User Account Control which on the docs, and I learned docker to build it, but I meet some problems, I looked for the solution in these issues, and I
    found my problems are the seem to Orthanc docker-compose file missing #785 .

My chores have been dealt with, and I will study the documentation and how to deploy the application in the near future.
My English is a little poor ,but I really appreciate that! Thanks again!

@dannyrb
Copy link
Member
dannyrb commented Sep 27, 2019

@lrqlrq, it does look like default.js is missing. In the latest version, master, this would be app-config.js. It should be produced when you run yarn run build from the repository root, alongside the rest of the progressive web application's static assets.

yarn run build --> <repo-root>/platform/viewer/dist/**/*

You can see how the Dockerfile in the root of this repository builds that output, and then uses it in an nginx image:

https://github.com/OHIF/Viewers/blob/master/Dockerfile#L60

@stale
Copy link
stale bot commented Oct 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Oct 18, 2019
@dannyrb dannyrb closed this as completed Oct 20, 2019
@Diegovictorbr
Copy link

I think my problem relates to this. I have a Tomcat folder called ohif where i want to deploy platform/viewer/dist content. However, OHIF is not able to find its static files. Here is a screenshot of what happens:

Sem título

Tomcat runs at http://149.56.20.137:17545 and i want to serve OHIF at http://149.56.20.137:17545/ohif

I am trying to connect OHIF with an Orthanc instance behind a NGINX reverse proxy.

@dannyrb
Copy link
Member
dannyrb commented Jan 13, 2020

@Diegovictorbr, can you ask this question in a new issue? This one is closed and older. We tend to not revisit these for new questions.

@OHIF OHIF locked as off-topic and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dannyrb dannyrb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dannyrb @Diegovictorbr @RainMaker-Q
0