8000 Trigger bingo.card_pos not reset on game start · Issue #77 · NeunEinser/bingo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Trigger bingo.card_pos not reset on game start #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UnlucksMcGee opened this issue Nov 2, 2021 · 3 comments
Closed

Trigger bingo.card_pos not reset on game start #77

UnlucksMcGee opened this issue Nov 2, 2021 · 3 comments
Labels
bug Something isn't working ! high prio
Milestone

Comments

@UnlucksMcGee
Copy link
Contributor

After joining a game, the trigger bingo.card_pos does not get reset, and therefore shows up in the tab list when typing /trigger
image
Is there a particular reason why you commented out the line in this commit?
In my opinion, I think the user should only have access to that trigger in the lobby.

@NeunEinser
Copy link
Owner
NeunEinser commented Nov 2, 2021

The reason it is commented is bad implementation, basically.

The trigger is not only used to trigger it but it actually also stores the selected value. So resetting it would mean currently that the user's value is set to something that is undefined. That means it would always be in the default position, even disregarding offhand items.
The easy solution here would be to use the bingo.pref trigger in the menu and use card_pos as the storage.

I kind of want to look into incorporating the card into the hud components system as well though, which then would make the card_pos objective completely unnecessary.

The next release should have one of these fixes employed though, as triggering it by accident can have (and actually will have in most cases) bad side effects, most notably completely hiding the card. I just noticed this too late to solve it for the beta2 release, and it's an issue that was present in all previous versions.

@NeunEinser NeunEinser added bug Something isn't working ! high prio labels Nov 2, 2021
@UnlucksMcGee
Copy link
Contributor Author

One workaround is to execute as @a run trigger bingo.card_pos add 0 which will effectively disable the trigger but it keeps its current score.

@NeunEinser
Copy link
Owner
NeunEinser commented Nov 2, 2021

Ohh, that's a clever way to disable a trigger!

@NeunEinser NeunEinser added this to the 5.0 Release milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ! high prio
Projects
None yet
Development

No branches or pull requests

2 participants
0