8000 Timer visually starts before the players can move · Issue #49 · NeunEinser/bingo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Timer visually starts before the players can move #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
opl- opened this issue May 21, 2021 · 5 comments
Closed

Timer visually starts before the players can move #49

opl- opened this issue May 21, 2021 · 5 comments
Labels
bug Something isn't working v low prio

Comments

@opl-
Copy link
opl- commented May 21, 2021

The game timer currently starts counting down while the world isn't yet generated and players are in the lobby. It'd make more sense for it to start the moment players can start moving and breaking blocks.
@MalbaCato
Copy link

The timer is reset back to 0 the moment the game starts so this is irrelevant. Don't close the issue tho, as neun seems not to be tracking that this needs to be fixed, as the times should not be shown (or kept at 0) before the game starts.

@NeunEinser
Copy link
Owner

Do you mean the keeping progress of gametime which counts up?
That's being reset once the game starts, the counting during setup is a display bug (I do use a worldborder timer for a different purpose there and currently that's displayed there as well)

@NeunEinser
Copy link
Owner

I am just going to assume above is what you mean and this will be used to track that issue. If there is another bug, feel free to open another issue.

@NeunEinser NeunEinser added the bug Something isn't working label May 22, 2021
@opl-
Copy link
Author
opl- commented May 22, 2021

The timer is reset back to 0 the moment the game starts so this is irrelevant.

I did not realize that, though it does make sense. Still, it was rather confusing to see it tick up. Feel free to rename the issue title to better describe what the intended behavior is.

@NeunEinser NeunEinser changed the title Timer starts before the players can move Timer visually starts before the players can move Aug 31, 2021
@NeunEinser
Copy link
Owner

Fixed in 86ca12e

Sign up for free to join this conversation on GitHub. Alre 4847 ady have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v low prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@opl- @NeunEinser @MalbaCato
0