10000 Filter and neuron pruning don't work in scheme composer (lite branch) · Issue #6 · NVlabs/condensa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Filter and neuron pruning don't work in scheme composer (lite branch) #6
Open
@cameronshinn

Description

@cameronshinn

Filter and neuron pruning do not have add_mask_to_module() support so there is a NotImplementedError raised here or here. I was thinking I could catch and handle this exception since the masks aren't a necessity, but raising the exception breaks out of the for loop iterating over the layers in the scheme composer and leaves the remaining layers dense.

I am pretty sure saving the masks in the layer module isn't a necessity, so raising an exception seems like overkill because it stops the model from being pruned. You could also handle the exception inside the scheme composer's for loop so that it doesn't break out and is able to prune all the layers.

I can submit a PR myself if you want to describe which route you want to take for fixing this. Obviously supporting mask saving for filter and neuron pruning would also work, but I'm not sure what work needs to be done for that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0