Add nemo-toolkit dependency to gpuCI
#480
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
sarahyurick
commented
Jan 10, 2025
Comment on lines
-110
to
-117
| # Installs bitext curation modules | ||
| bitext = [ | ||
| "huggingface-hub", | ||
| "tqdm", | ||
| "transformers", | ||
| "nemo_curator[cuda12x]", | ||
| ] |
There was a problem hiding this comment.
Looking at #193 it does not look like the cuda12x dependencies are strictly needed here? Also, I believe all of huggingface-hub, tqdm, and transformers are already being installed either directly or indirectly.
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
nemo-toolkit dependencynemo-toolkit dependency to gpuCI
Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #376.