8000 Expand rmean_type for other aggregation metrics · Issue #1408 · NGEET/fates · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expand rmean_type for other aggregation metrics #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mpaiao opened this issue May 13, 2025 · 0 comments
Open

Expand rmean_type for other aggregation metrics #1408

mpaiao opened this issue May 13, 2025 · 0 comments

Comments

@mpaiao
Copy link
Contributor
mpaiao commented May 13, 2025 •
edited
Loading

Task description

I am working on implementing a btran-based metric for drought deciduous phenology (main issue #1385), and I think for it to really work and avoid hydraulic failure mortality, we need to track the minimum daily btran instead of the daily average. I imagine at some point we may want a similar capability for maximum daily value, so I will likely implement it as well.

This is how I plan to implement this in FatesRunningMeanMod:

  1. Edit rmean_type class to add four more variables (c_minimum, l_minimum, c_maximum, l_maximum.
  2. Add functions GetMin and GetMax to retrieve the minimum and maximum.
  3. Edit functions InitRMean, UpdateRMean, FuseRMean and CopyFromDonor so they handle the new variables too.
  4. Existing flag moving_ema_window will be applied to the mean only, not the minima and maxima, which will always use the fixed windows.

With this, it may make sense to rename the module, structure names and functions. I am thinking of FatesRunningSummaryMod, rsummary_def_type and rsummary_type, InitRSummary, etc. but I am open to other suggestions (including not changing it at all). Also, I suppose I should make this a separate pull request before bringing in the btran-based phenology, what do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
FATES issue board
Status: ❕Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpaiao
0