8000 Clean Up HF Conversion & Adapter · Issue #309 · Modalities/modalities · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean Up HF Conversion & Adapter #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
flxst opened this issue Feb 25, 2025 · 0 comments
Open

Clean Up HF Conversion & Adapter #309

flxst opened this issue Feb 25, 2025 · 0 comments

Comments

@flxst
Copy link
Member
flxst commented Feb 25, 2025

Modalities currently supports two separate ways to convert Modalities checkpoints such that they can be used with HuggingFace:

  1. Conversion to an HF Adapter
  2. Conversion to an HF Checkpoint

Recent PRs include e.g. #285, #306 for 1) and #305 for 2)

There are a few issues that need to be resolved:

  • We need to decide whether we want to continue supporting both 1) and 2). Maybe 1) is enough?
  • The term "conversion" is used for both 1) and 2). We should perhaps rename everything regarding 2)
  • Regarding 2) - if we decide to keep it - some refactoring is needed. The directories in src/modalities/models should be moved elsewhere. There is also code in src/modalities/checkpointing and a modalities CLI endpoint.
  • Regarding 1), we should implement a modalities CLI endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flxst
0