8000 After updating to version 95.1.6, desynchronization was observed, · Issue #3999 · MirrorNetworking/Mirror · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

After updating to version 95.1.6, desynchronization was observed, #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dannisliang opened this issue Mar 17, 2025 · 3 comments
Open

After updating to version 95.1.6, desynchronization was observed, #3999

dannisliang opened this issue Mar 17, 2025 · 3 comments
Labels
can't reproduce question Further information is requested

Comments

@dannisliang
Copy link

After updating to version 95.1.6, desynchronization was observed, and the issue appears to be caused by this particular logic segment.

                byte[] payloadCopy = new byte[message.payload.Count];
                Array.Copy(message.payload.Array, message.payload.Offset, payloadCopy, 0, message.payload.Count);
                SpawnMessage messageCopy = new SpawnMessage
                {
                    netId = message.netId,
                    spawnFlags = message.spawnFlags, // Preserves isOwner and isLocalPlayer via flags
                    sceneId = message.sceneId,
                    assetId = message.assetId,
                    position = message.position,
                    rotation = message.rotation,
                    scale = message.scale,
                    payload = new ArraySegment<byte>(payloadCopy)
                };
                spawned[message.netId] = identity;
                pendingSpawns[identity] = messageCopy;
@dannisliang
Copy link
Author

The issue still persists after updating to version v96.0.1.

@MrGadget1024
Copy link
Collaborator

The issue still persists after updating to version v96.0.1.

Elaborate on what you mean by "desynchronization". How to reproduce using any of our examples?

@MrGadget1024 MrGadget1024 added question Further information is requested can't reproduce labels Mar 24, 2025
@dannisliang
Copy link
Author

I've found that this is the cause of the problem. Calling SetClientReady multiple times under certain error conditions may lead to pendingSpawns.Clear();. Should I add if (conn.isReady) return; inside SetClientReady?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
can't reproduce question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dannisliang @MrGadget1024
0