8000 Allow Kubernetes to supply pod's fsgroup to CSI driver on mount · Issue #2317 · kubernetes/enhancements · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Kubernetes to supply pod's fsgroup to CSI driver on mount #2317

Closed
12 tasks done
gnufied opened this issue Jan 22, 2021 · 55 comments
Closed
12 tasks done

Allow Kubernetes to supply pod's fsgroup to CSI driver on mount #2317

gnufied opened this issue Jan 22, 2021 · 55 comments
Assignees
@bertinatto
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone
v1.26

Comments

@gnufied
Copy link
Member
gnufied commented Jan 22, 2021 •
edited
Loading

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 22, 2021
@gnufied
Copy link
Member Author
gnufied commented Jan 22, 2021

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2021
@gnufied
Copy link
Member Author
gnufied commented Jan 22, 2021

/assign

@gnufied gnufied mentioned this issue Jan 25, 2021
Merged
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 26, 2021
@annajung annajung added this to the v1.21 milestone Jan 26, 2021
@jrsapi
Copy link
jrsapi commented Feb 1, 2021

@gnufied This is Joseph v1.21 enhancement shadow. A reminder for this enhancement to be included in the 1.21 milestone, it must meet the following criteria:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have a production readiness review

Starting 1.21, all KEPs must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this.

@jrsapi
Copy link
jrsapi commented Feb 8, 2021 •
edited
Loading

Greetings @gnufied @msau42,

Checking in and reminding that Enhancements Freeze is 2 days away, Feb 9th EOD PST.

Enhancements team is aware that the KEP update is currently in progress (PR #2323 ) and we're tracking it.
Any enhancements that do not complete the following requirements by the freeze will require an exception.

[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review

@msau42
Copy link
Member
msau42 commented Feb 8, 2021

@jrsapi the kep has merged 6 days ago and has met all the crtieria. Can you confirm there is nothing else we need to do?

@annajung
Copy link
Contributor
annajung commented Feb 8, 2021

With #2323 merged, this enhancement has met all criteria for the enhancements freeze 👍

@jrsapi
Copy link
jrsapi commented Feb 18, 2021

Greetings @gnufied,
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

@jrsapi
Copy link
jrsapi commented Mar 2, 2021

Greetings @gnufied,
The enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so the release team can track it.

@annajung
Copy link
Contributor

Hi @gnufied, with code freeze now in effect, we are removing this enhancement from 1.21 release due to no code PR being tracked for this enhancement.

If needed, feel free to file an exception to add this back into the release. thanks!

@annajung annajung removed this from the v1.21 milestone Mar 10, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 10, 2021
@JamesLaverack
Copy link
Member

/milestone 1.22

@k8s-ci-robot
Copy link
Contributor

@JamesLaverack: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.25]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JamesLaverack
Copy link
Member

Whoops.
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 28, 2021
@reylejano
Copy link
Member
reylejano commented May 10, 2021 •
edited
Loading

Hi @gnufied,

1.22 release team here. After reviewing the kep and the approved PRR, this enhancements is in good shape for the 1.22 Enhancements Freeze at 23:59:59 pst on Thursday, May 13. A few updates to the KEP are required before Enhancements Freeze:

  • In the KEP README.md, update the missing sections for Implementation History , Drawbacks , and Alternatives. Here's an example KEP

@reylejano
Copy link
Member

Hi @gnufied , please see my comment above on changes required to make the 1.22 Enhancements Freeze which starts on Thursday, May 13 at 23:59:59 pst

@gnufied gnufied mentioned this issue May 12, 2021
Merged
@gnufied
Copy link
Member Author
gnufied commented May 12, 2021

@reylejano I opened #2723 to fill those sections.

@reylejano
Copy link
Member

Hi @gnufied , with the merge of PR 2723, this enhancement is all set for the 1.22 Enhancements Freeze 🎉
Thank you!

@ritpanjw
Copy link

Hello @gnufied 👋 , 1.22 Docs Shadow here.

This enhancement is marked as Needs Docs for 1.22 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@xing-yang xing-yang moved this from Needs Work to KEP Approved in 1.26 release Oct 4, 2022
@marosset
Copy link
Contributor
marosset commented Oct 5, 2022

Hello @gnufied, @verult, and @bertinatto 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

At a minimum the I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement. must be acknowledged. Please try and list the unit test coverage for all touched packages as well or explain why this is not applicable.

@bertinatto
Copy link
Member

@marosset can you point me to what exactly is missing in the Test Plan section?
The only difference I see is in the title leval, I don't see any missing information?

@marosset
Copy link
Contributor
marosset commented Oct 6, 2022

@marosset can you point me to what exactly is missing in the Test Plan section? The only difference I see is in the title leval, I don't see any missing information?

Hi @bertinatto -
Please include (and check)
image

Also,
Please follow the instructions in the comments in KEP template for the sections in Test Plan

  • For Unit tests enumerate the core packages this feature has touched and note the unit test coverage
  • For Integration tests link to any applicable tests
  • For e2e tests link to any applicable tests

@gnufied
Copy link
Member Author
gnufied commented Oct 6, 2022

@marosset So the only thing missing in unit test links right? The KEP already links e2e tests and it explicitly mentions that integration tests don't apply to this KEP.

To be clear - the feature does have extensive unit tests too. See:

- pkg/volume/csi/csi_mounter_test.go:679
- pkg/volume/csi/csi_attacher_test.go:1094

@marosset
Copy link
Contributor
marosset commented Oct 6, 2022

For the e2e tests the KEP template comments asks:

This question should be filled when targeting a release.
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.

For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
https://storage.googleapis.com/k8s-triage/index.html

We expect no non-infra related flakes in the last month as a GA graduation criteria.

It looks like the current README.md is just linking to the e2e test source.

Also - and this is the most important part -
the README.md must include

[x] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

from the KEP template.

@bertinatto bertinatto mentioned this issue Oct 6, 2022
Merged
@marosset
Copy link
Contributor
marosset commented Oct 6, 2022

With #3598 merged - this KEP is now tracked for the v1.26 release cycle.
Thanks!

@rhockenbury
Copy link

Hi @gnufied and @verult 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any k/k PRs. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue.

As always, we are here to help should questions come up. Thanks!

@bertinatto bertinatto mentioned this issue Oct 31, 2022
Merged
@xing-yang
Copy link
Contributor

The main PR is here: kubernetes/kubernetes#113225

@rhockenbury
Copy link

I have this marked as tracked for code freeze.

@krol3
Copy link
krol3 commented Nov 9, 2022

Hello @gnufied 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@bertinatto
Copy link
Member

Hi @krol3, the docs PR is linked in the description, but I realize the checkbox is not marked. Is that the only thing missing?

@gnufied could you check that box?

@krol3
Copy link
krol3 commented Nov 9, 2022

Hi @bertinatto how are you? I can see only the blog-PR, it's missing the doc-PR related to update for example: Feature gates for Alpha or Beta features table:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

@bertinatto
Copy link
Member

Hi @krol3, we just updated the PR description. The docs PR is this one: kubernetes/website#37700

@bertinatto bertinatto mentioned this issue Nov 9, 2022
Merged
@marosset
Copy link
Contributor

Hi @gnufied, @verult, and/or @bertinatto - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/2317-fsgroup-on-mount/kep.yaml setting the status to implemented and then close this issue.
Thanks!

@marosset marosset removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Dec 12, 2022
@bertinatto bertinatto mentioned this issue Dec 13, 2022
Merged
@bertinatto
Copy link
Member

Hi @marosset, I created a PR to change the status: #3689

Closing this issue, please re-open if there's anything missing.

Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@bertinatto: Closing this issue.

In response to this:

Hi @marosset, I created a PR to change the status: #3689

Closing this issue, please re-open if there's anything missing.

Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Repository owner moved this from Todo to Done in 1.25 Release Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertinatto bertinatto

Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
(Test board) Kubernetes 1.26 Enhancements Tracking
Status: New New
1.26 Enhancements Tracking
Status: Graduating
Milestone
v1.26
Development

No branches or pull requests
0